]> git.proxmox.com Git - mirror_qemu.git/commit - block/vpc.c
vpc: Return 0 from vpc_co_create() on success
authorMax Reitz <mreitz@redhat.com>
Mon, 2 Sep 2019 19:33:16 +0000 (21:33 +0200)
committerKevin Wolf <kwolf@redhat.com>
Tue, 10 Sep 2019 06:58:43 +0000 (08:58 +0200)
commit1a37e3124407b5a145d44478d3ecbdb89c63789f
tree4d588f07e8984bc24218fd47a410b22f0ec1d812
parenteffecce6bcb830a661c882d7299b53382b56a131
vpc: Return 0 from vpc_co_create() on success

blockdev_create_run() directly uses .bdrv_co_create()'s return value as
the job's return value.  Jobs must return 0 on success, not just any
nonnegative value.  Therefore, using blockdev-create for VPC images may
currently fail as the vpc driver may return a positive integer.

Because there is no point in returning a positive integer anywhere in
the block layer (all non-negative integers are generally treated as
complete success), we probably do not want to add more such cases.
Therefore, fix this problem by making the vpc driver always return 0 in
case of success.

Suggested-by: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-stable@nongnu.org
Signed-off-by: Max Reitz <mreitz@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
block/vpc.c