]> git.proxmox.com Git - mirror_qemu.git/commit - block.c
block: Fix flags in reopen queue
authorFam Zheng <famz@redhat.com>
Tue, 13 Mar 2018 14:20:02 +0000 (22:20 +0800)
committerKevin Wolf <kwolf@redhat.com>
Mon, 19 Mar 2018 11:01:39 +0000 (12:01 +0100)
commit1a5297366fe0d11e28fce694fc4377b85afca1da
tree4184b7cb77e45dd56c24e33226b66067f59be31c
parente38105748f09d6285df54b64f4ca13bd60613e72
block: Fix flags in reopen queue

Reopen flags are not synchronized according to the
bdrv_reopen_queue_child precedence until bdrv_reopen_prepare. It is a
bit too late: we already check the consistency in bdrv_check_perm before
that.

This fixes the bug that when bdrv_reopen a RO node as RW, the flags for
backing child are wrong. Before, we could recurse with flags.rw=1; now,
role->inherit_options + update_flags_from_options will make sure to
clear the bit when necessary.  Note that this will not clear an
explicitly set bit, as in the case of parallel block jobs (e.g.
test_stream_parallel in 030), because the explicit options include
'read-only=false' (for an intermediate node used by a different job).

Signed-off-by: Fam Zheng <famz@redhat.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
block.c