]> git.proxmox.com Git - mirror_qemu.git/commit - block.c
block: improve permission conflict error message
authorVladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Tue, 1 Jun 2021 07:52:18 +0000 (10:52 +0300)
committerKevin Wolf <kwolf@redhat.com>
Wed, 2 Jun 2021 12:23:20 +0000 (14:23 +0200)
commit30ebb9aa9203b5051c5c4f4e2421803b94e5f2cc
tree636ee716a8031971eadd6bff3ffd4e0ce6ec4b84
parentda261b69aee9acb46ac1b0ebfe0ccb7b74450a88
block: improve permission conflict error message

Now permissions are updated as follows:
 1. do graph modifications ignoring permissions
 2. do permission update

 (of course, we rollback [1] if [2] fails)

So, on stage [2] we can't say which users are "old" and which are
"new" and exist only since [1]. And current error message is a bit
outdated. Let's improve it, to make everything clean.

While being here, add also a comment and some good assertions.

iotests 283, 307, qsd-jobs outputs are updated.

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Message-Id: <20210601075218.79249-7-vsementsov@virtuozzo.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
block.c
tests/qemu-iotests/283.out
tests/qemu-iotests/307.out
tests/qemu-iotests/tests/qsd-jobs.out