]> git.proxmox.com Git - mirror_qemu.git/commit - block.c
block: Don't copy backing file name on error
authorMax Reitz <mreitz@redhat.com>
Sat, 26 Oct 2013 13:44:43 +0000 (15:44 +0200)
committerKevin Wolf <kwolf@redhat.com>
Mon, 28 Oct 2013 16:35:52 +0000 (17:35 +0100)
commit61ed2684539f7f31304e193d7c0e68d57ce6be88
tree611df1028c679cdfc23e4d40dd8acf918c05ae6e
parentd1f3a23bfac4fe38056ab5e07186939b7be8852b
block: Don't copy backing file name on error

bdrv_open_backing_file() tries to copy the backing file name using
pstrcpy directly after calling bdrv_open() to open the backing file
without checking whether that was actually successful. If it was not,
ps->backing_hd->file will probably be NULL and qemu will crash.

Fix this by moving pstrcpy after checking whether bdrv_open() succeeded.

Signed-off-by: Max Reitz <mreitz@redhat.com>
Reviewed-by: Benoit Canet <benoit@irqsave.net>
Reviewed-by: Amos Kong <kongjianjun@gmail.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
block.c