]> git.proxmox.com Git - mirror_qemu.git/commit - block.c
block: Print its file name if backing file opening failed
authorFam Zheng <famz@redhat.com>
Fri, 8 Nov 2013 03:26:49 +0000 (11:26 +0800)
committerKevin Wolf <kwolf@redhat.com>
Thu, 14 Nov 2013 12:09:06 +0000 (13:09 +0100)
commitb04b6b6ec3a1e0ba90c2f58617286d9fc35fa372
tree3a02580b238e0f85eb5443eb4b7011d7d7fa4169
parent5c5432e7d630592ddcc1876ac8a1505f8f14ef15
block: Print its file name if backing file opening failed

If backing file doesn't exist, the error message is confusing and
misleading:

    $ qemu /tmp/a.qcow2
    qemu: could not open disk image /tmp/a.qcow2: Could not open file: No
    such file or directory

But...

    $ ls /tmp/a.qcow2
    /tmp/a.qcow2

    $ qemu-img info /tmp/a.qcow2
    image: /tmp/a.qcow2
    file format: qcow2
    virtual size: 8.0G (8589934592 bytes)
    disk size: 196K
    cluster_size: 65536
    backing file: /tmp/b.qcow2

Because...

    $ ls /tmp/b.qcow2
    ls: cannot access /tmp/b.qcow2: No such file or directory

This is not intuitive. It's better to have the missing file's name in
the error message. With this patch:

    $ qemu-io -c 'read 0 512' /tmp/a.qcow2
    qemu-io: can't open device /tmp/a.qcow2: Could not open backing
    file: Could not open '/stor/vm/arch.raw': No such file or directory
    no file open, try 'help open'

Which is a little bit better.

Signed-off-by: Fam Zheng <famz@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
block.c
block/raw-posix.c
block/raw-win32.c
tests/qemu-iotests/051.out
tests/qemu-iotests/069.out