]> git.proxmox.com Git - mirror_qemu.git/commit - block.c
block: set bs->read_only before .bdrv_open()
authorStefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Thu, 27 Oct 2011 09:54:27 +0000 (10:54 +0100)
committerKevin Wolf <kwolf@redhat.com>
Fri, 28 Oct 2011 17:25:49 +0000 (19:25 +0200)
commite7c637967e6aad195b5f30cfd995913c9e0b4666
treebdb6b7464a29eed0258efc6221b2b89dc61110b5
parentb46578555c4bce64e3daba4591334aba2d12c156
block: set bs->read_only before .bdrv_open()

Several block drivers set bs->read_only in .bdrv_open() but
block.c:bdrv_open_common() clobbers its value.  Additionally, QED uses
bdrv_is_read_only() in .bdrv_open() to decide whether to perform
consistency checks.

The correct ordering is to initialize bs->read_only from the open flags
before calling .bdrv_open().  This way block drivers can override it if
necessary and can use bdrv_is_read_only() in .bdrv_open().

Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
block.c