]> git.proxmox.com Git - mirror_qemu.git/commit - blockdev.c
qapi: block-stream: add "bottom" argument
authorVladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Wed, 16 Dec 2020 06:17:00 +0000 (09:17 +0300)
committerMax Reitz <mreitz@redhat.com>
Tue, 26 Jan 2021 13:36:37 +0000 (14:36 +0100)
commit7f4a396d76670bbffd6c3ba9a550a1bb62ae6267
tree0cb718a392fc28a374d2afd8e25294726798fc5c
parent000e5a1cda09e18af91556a39b5a4f1214becb3c
qapi: block-stream: add "bottom" argument

The code already don't freeze base node and we try to make it prepared
for the situation when base node is changed during the operation. In
other words, block-stream doesn't own base node.

Let's introduce a new interface which should replace the current one,
which will in better relations with the code. Specifying bottom node
instead of base, and requiring it to be non-filter gives us the
following benefits:

 - drop difference between above_base and base_overlay, which will be
   renamed to just bottom, when old interface dropped

 - clean way to work with parallel streams/commits on the same backing
   chain, which otherwise become a problem when we introduce a filter
   for stream job

 - cleaner interface. Nobody will surprised the fact that base node may
   disappear during block-stream, when there is no word about "base" in
   the interface.

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Message-Id: <20201216061703.70908-11-vsementsov@virtuozzo.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
Signed-off-by: Max Reitz <mreitz@redhat.com>
block/monitor/block-hmp-cmds.c
block/stream.c
blockdev.c
include/block/block_int.h
qapi/block-core.json