]> git.proxmox.com Git - mirror_qemu.git/commit - blockdev.c
block: Add Error parameter to bdrv_append()
authorKevin Wolf <kwolf@redhat.com>
Mon, 20 Feb 2017 11:46:42 +0000 (12:46 +0100)
committerKevin Wolf <kwolf@redhat.com>
Tue, 28 Feb 2017 19:47:51 +0000 (20:47 +0100)
commitb2c2832c6140cfe3ddc0de2d77eeb0b77dea8fd3
treea8887134fb47b8dbd8c23a0cd4da55bc979ecbbb
parent12fa4af61fb2a08b156134c3b6717534c637c995
block: Add Error parameter to bdrv_append()

Aborting on error in bdrv_append() isn't correct. This patch fixes it
and lets the callers handle failures.

Test case 085 needs a reference output update. This is caused by the
reversed order of bdrv_set_backing_hd() and change_parent_backing_link()
in bdrv_append(): When the backing file of the new node is set, the
parent nodes are still pointing to the old top, so the backing blocker
is now initialised with the node name rather than the BlockBackend name.

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Acked-by: Fam Zheng <famz@redhat.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
block.c
block/mirror.c
blockdev.c
include/block/block.h
tests/qemu-iotests/085.out