]> git.proxmox.com Git - mirror_qemu.git/commit - bsd-user/mmap.c
bsd-user/mmap.c: assert that target_mprotect cannot fail
authorWarner Losh <imp@bsdimp.com>
Fri, 17 Sep 2021 15:16:54 +0000 (09:16 -0600)
committerWarner Losh <imp@bsdimp.com>
Mon, 18 Oct 2021 18:51:38 +0000 (12:51 -0600)
commit91a5adda1583fa8a3166bc16d79c67f3c87e958b
treeb93af69216b1d59fd20c97bb410efcaa7054df86
parent0fc76b685989d30a32316b17a9c43ba017e114a1
bsd-user/mmap.c: assert that target_mprotect cannot fail

Similar to the equivalent linux-user change 86abac06c14. All error
conditions that target_mprotect checks are also checked by target_mmap.
EACCESS cannot happen because we are just removing PROT_WRITE.  ENOMEM
should not happen because we are modifying a whole VMA (and we have
bigger problems anyway if it happens).

Fixes a Coverity false positive, where Coverity complains about
target_mprotect's return value being passed to tb_invalidate_phys_range.

Signed-off-by: Mikaël Urankar <mikael.urankar@gmail.com>
Signed-off-by: Warner Losh <imp@bsdimp.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Kyle Evans <kevans@FreeBSD.org>
bsd-user/mmap.c