]> git.proxmox.com Git - mirror_qemu.git/commit - chardev/spice.c
spice-qemu-char: Fix flow control in client -> guest direction
authorHans de Goede <hdegoede@redhat.com>
Tue, 22 Mar 2011 15:28:41 +0000 (16:28 +0100)
committerGerd Hoffmann <kraxel@redhat.com>
Mon, 6 Jun 2011 07:14:42 +0000 (09:14 +0200)
commit35106c2df2eda83e5f7fea356d80c11fed93df1f
tree5a655d30bd2572f3493e9af5d62d27c19d56357f
parentd800040fb47fe4500d1f8bf604b9fd129bda9419
spice-qemu-char: Fix flow control in client -> guest direction

In the old spice-vmc device we used to have:
last_out = virtio_serial_write(&svc->port, p, MIN(len, VMC_MAX_HOST_WRITE));
if (last_out > 0)
   ...

Now in the chardev backend we have:
last_out = MIN(len, VMC_MAX_HOST_WRITE);
qemu_chr_read(scd->chr, p, last_out);
if (last_out > 0) {
   ...

Which causes us to no longer detect if the virtio port is not ready
to receive data from us. chardev actually has a mechanism to detect this,
but it requires a separate call to qemu_chr_can_read, before calling
qemu_chr_read (which return void).

This patch uses qemu_chr_can_read to fix the flow control from client to
guest.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
spice-qemu-char.c