]> git.proxmox.com Git - mirror_qemu.git/commit - configure
configure: Add a proper check for openpty() in libutil
authorThomas Huth <thuth@redhat.com>
Thu, 17 Jan 2019 17:14:08 +0000 (18:14 +0100)
committerPaolo Bonzini <pbonzini@redhat.com>
Tue, 5 Feb 2019 15:50:16 +0000 (16:50 +0100)
commitd99e97e6912d90a55e9a92e004dd54513da2848a
treeeba7e1b8e95168dbfb5404a7e92fd0aef27ae508
parent6aaa24f9d494a46c0a5aa5c7202cf50b3a7075ef
configure: Add a proper check for openpty() in libutil

On Linux (and maybe some BSDs), we require libutil for the openpty()
function. However, this library is not available on some other systems, so
we currently use a fragile if-statement in the configure script to check
whether we need the library or not. Unfortunately, we also hard-coded a
"-lutil" in the tests/Makefile.include file, so this breaks the build on
Solaris, for example (see buglink below). To fix the issue, add the "-lutil"
to "libs_tools" in the configure script instead, then this gets properly
propagated to the tests, too.
And while we're at it, also replace the fragile if-statement in the confi-
gure script with a proper link-check for the availability of this function.

Buglink: https://bugs.launchpad.net/qemu/+bug/1777252
Signed-off-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
configure
tests/Makefile.include