]> git.proxmox.com Git - qemu.git/commit - configure
coroutine: add ./configure --disable-coroutine-pool
authorStefan Hajnoczi <stefanha@redhat.com>
Wed, 11 Sep 2013 14:42:35 +0000 (16:42 +0200)
committerKevin Wolf <kwolf@redhat.com>
Thu, 12 Sep 2013 08:12:48 +0000 (10:12 +0200)
commit70c60c089fdc6bf8a79324e492c13e8c08d55942
tree03f26370db88432b5808f3a6a5c3c4bce229eaf5
parent2c78857bf6a9b5d06e17533b8f40fee14e087987
coroutine: add ./configure --disable-coroutine-pool

The 'gthread' coroutine backend was written before the freelist (aka
pool) existed in qemu-coroutine.c.

This means that every thread is expected to exit when its coroutine
terminates.  It is not possible to reuse threads from a pool.

This patch automatically disables the pool when 'gthread' is used.  This
allows the 'gthread' backend to work again (for example,
tests/test-coroutine completes successfully instead of hanging).

I considered implementing thread reuse but I don't want quirks like CPU
affinity differences due to coroutine threads being recycled.  The
'gthread' backend is a reference backend and it's therefore okay to skip
the pool optimization.

Note this patch also makes it easy to toggle the pool for benchmarking
purposes:

  ./configure --with-coroutine-backend=ucontext \
              --disable-coroutine-pool

Reported-by: Gabriel Kerneis <gabriel@kerneis.info>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Gabriel Kerneis <gabriel@kerneis.info>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
configure
qemu-coroutine.c