]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit - crypto/ahash.c
crypto: hash - Remove VLA usage
authorKees Cook <keescook@chromium.org>
Tue, 7 Aug 2018 21:18:38 +0000 (14:18 -0700)
committerHerbert Xu <herbert@gondor.apana.org.au>
Tue, 4 Sep 2018 03:35:03 +0000 (11:35 +0800)
commitb68a7ec1e9a3efac53ae26a1658a553825a2375c
tree6ad87c86f0fc4aeafee091c6d43043876f081d0b
parentebf533adc877d9171800bbce77372d8051fc35c2
crypto: hash - Remove VLA usage

In the quest to remove all stack VLA usage from the kernel[1], this
removes the VLAs in SHASH_DESC_ON_STACK (via crypto_shash_descsize())
by using the maximum allowable size (which is now more clearly captured
in a macro), along with a few other cases. Similar limits are turned into
macros as well.

A review of existing sizes shows that SHA512_DIGEST_SIZE (64) is the
largest digest size and that sizeof(struct sha3_state) (360) is the
largest descriptor size. The corresponding maximums are reduced.

[1] https://lkml.kernel.org/r/CA+55aFzCG-zNmZwX4A2FQpadafLfEzK6CC=qPXydAacU1RqZWA@mail.gmail.com

Signed-off-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
crypto/ahash.c
crypto/algif_hash.c
crypto/shash.c
include/crypto/hash.h