]> git.proxmox.com Git - mirror_qemu.git/commit - crypto/tlscreds.c
crypto: avoid two coverity false positive error reports
authorDaniel P. Berrange <berrange@redhat.com>
Fri, 13 Nov 2015 17:45:27 +0000 (17:45 +0000)
committerMichael Tokarev <mjt@tls.msk.ru>
Fri, 4 Dec 2015 06:39:55 +0000 (09:39 +0300)
commit0e1d02452bf2c3486406dd48524a5b1de3c0eba8
tree351554876a7e6e6b2f3a8dd651758266fbe65d1c
parent0ef74c7496fd3c526b2259f86326eca4b3a03b78
crypto: avoid two coverity false positive error reports

In qcrypto_tls_creds_get_path() coverity complains that
we are checking '*creds' for NULL, despite having
dereferenced it previously. This is harmless bug due
to fact that the trace call was too early. Moving it
after the cleanup gets the desired semantics.

In qcrypto_tls_creds_check_cert_key_purpose() coverity
complains that we're passing a pointer to a previously
free'd buffer into gnutls_x509_crt_get_key_purpose_oid()
This is harmless because we're passing a size == 0, so
gnutls won't access the buffer, but rather just report
what size it needs to be. We can avoid it though by
explicitly setting the buffer to NULL after free'ing
it.

Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
crypto/tlscreds.c
crypto/tlscredsx509.c