]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit - drivers/acpi/acpi_lpss.c
ACPI / LPSS: Add missing prv_offset setting for byt/cht PWM devices
authorHans de Goede <hdegoede@redhat.com>
Thu, 26 Apr 2018 12:10:24 +0000 (14:10 +0200)
committerKleber Sacilotto de Souza <kleber.souza@canonical.com>
Mon, 14 Jan 2019 09:28:55 +0000 (09:28 +0000)
commitb3a16539dcdec94a22ea83f0f8ec5070b2ce502d
tree86ca4f5bee06cc3d82e9d9df9679e6d7e73beaf8
parentbc70e018ff69d48bc310871e2ff8ea89dd99fcad
ACPI / LPSS: Add missing prv_offset setting for byt/cht PWM devices

BugLink: http://bugs.launchpad.net/bugs/1807469
commit fdcb613d49321b5bf5d5a1bd0fba8e7c241dcc70 upstream.

The LPSS PWM device on on Bay Trail and Cherry Trail devices has a set
of private registers at offset 0x800, the current lpss_device_desc for
them already sets the LPSS_SAVE_CTX flag to have these saved/restored
over device-suspend, but the current lpss_device_desc was not setting
the prv_offset field, leading to the regular device registers getting
saved/restored instead.

This is causing the PWM controller to no longer work, resulting in a black
screen,  after a suspend/resume on systems where the firmware clears the
APB clock and reset bits at offset 0x804.

This commit fixes this by properly setting prv_offset to 0x800 for
the PWM devices.

Cc: stable@vger.kernel.org
Fixes: e1c748179754 ("ACPI / LPSS: Add Intel BayTrail ACPI mode PWM")
Fixes: 1bfbd8eb8a7f ("ACPI / LPSS: Add ACPI IDs for Intel Braswell")
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Acked-by: Rafael J . Wysocki <rjw@rjwysocki.net>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
drivers/acpi/acpi_lpss.c