]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit - drivers/ata/libata-core.c
libata: Cleanup ata_read_log_page()
authorDamien Le Moal <damien.lemoal@wdc.com>
Mon, 10 Jul 2017 05:45:20 +0000 (14:45 +0900)
committerTejun Heo <tj@kernel.org>
Mon, 10 Jul 2017 17:41:04 +0000 (13:41 -0400)
commit7cfdfdc82a467c78af9132cb9c98e84415df34bc
tree90f99c2503733c02f301781219aa1f6a18bfdfa6
parentaccd04738f90c02c537378124de7c3cb5a511027
libata: Cleanup ata_read_log_page()

The warning message "READ LOG DMA EXT failed, trying unqueued" in
ata_read_log_page() as well as the macro name ATA_HORKAGE_NO_NCQ_LOG
are confusing: the command READ LOG DMA EXT is not an queued NCQ command
unless it is encapsulated in a RECEIVE FPDMA QUEUED command.
From ACS-4 READ LOG DMA EXT description:

"The device processes the READ LOG DMA EXT command in the NCQ feature
set environment (see 4.13.6) if the READ LOG DMA EXT command is
encapsulated in a RECEIVE FPDMA QUEUED command (see 7.30) with the
inputs encapsulated as shown in 7.23.6."

To avoid confusion, fix the warning messsage to mention switching to PIO and
not "unqueued" and rename the macro ATA_HORKAGE_NO_NCQ_LOG to
ATA_HORKAGE_NO_DMA_LOG.

Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com>
Reviewed-by: Hannes Reinecke <hare@suse.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
drivers/ata/libata-core.c
include/linux/libata.h