]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commit - drivers/block/drbd/drbd_nl.c
drbd: drbdsetup detach of an unresponsive local disk should not block IO "forever"
authorLars Ellenberg <lars.ellenberg@linbit.com>
Mon, 26 Jan 2015 10:35:38 +0000 (11:35 +0100)
committerJens Axboe <axboe@fb.com>
Wed, 25 Nov 2015 16:22:01 +0000 (09:22 -0700)
commit05a72772fcaae4ac88052b6c93aa0d116ff0a748
tree0a6e519cdbe2a9e3be221f13e40262375e9910e4
parent92f108b41efdeace60e354bb619c164b50abf6f8
drbd: drbdsetup detach of an unresponsive local disk should not block IO "forever"

When detaching, we make sure no application IO is in-flight
by internally suspending IO, then trigger the state change,
wait for the result, and finally internally resume IO again.

Once we triggered the stat change to "Failed",
we expect it to change from Failed to Diskless.
(To avoid races, we actually wait for it to leave "Failed").

On an unresponsive local IO backend, this may not happen, ever.
Don't have a "hung" detach block IO "forever", but resume IO
before waiting for the state change to Diskless.

We may well be able to continue IO to and from a healthy peer.

Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>
Signed-off-by: Jens Axboe <axboe@fb.com>
drivers/block/drbd/drbd_nl.c