]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit - drivers/block/nbd.c
nbd: don't start req until after the dead connection logic
authorJosef Bacik <jbacik@fb.com>
Mon, 6 Nov 2017 21:11:58 +0000 (16:11 -0500)
committerJens Axboe <axboe@kernel.dk>
Mon, 6 Nov 2017 21:15:04 +0000 (14:15 -0700)
commit6a468d5990ecd1c2d07dd85f8633bbdd0ba61c40
treeb3e4a8ef7e6a4a50f542afc8a3c9f2ab255032eb
parentff57dc94faec023abc267cdc45766fccff497557
nbd: don't start req until after the dead connection logic

We can end up sleeping for a while waiting for the dead timeout, which
means we could get the per request timer to fire.  We did handle this
case, but if the dead timeout happened right after we submitted we'd
either tear down the connection or possibly requeue as we're handling an
error and race with the endio which can lead to panics and other
hilarity.

Fixes: 560bc4b39952 ("nbd: handle dead connections")
Cc: stable@vger.kernel.org
Signed-off-by: Josef Bacik <jbacik@fb.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/block/nbd.c