]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commit - drivers/block/pktcdvd.c
pktcdvd: debugfs functions return NULL on error
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 6 Nov 2013 08:24:02 +0000 (09:24 +0100)
committerJens Axboe <axboe@kernel.dk>
Fri, 8 Nov 2013 16:10:31 +0000 (09:10 -0700)
commit49c2856af779bb1a36fa598804e4c0b2251fae57
tree6293d409321ebde9c07d9eea23ffcb4c95fdcf46
parentbfe11d6de1c416cea4f3f0f35f864162063ce3fa
pktcdvd: debugfs functions return NULL on error

My static checker complains correctly that this is potential NULL
dereference because debugfs functions return NULL on error.  They return
an ERR_PTR if they are configured out.

We don't need to check for ERR_PTR because if debugfs is stubbed out the
dummy functions won't complain about that.  We don't need to check the
values before calling debugfs_remove() because that accepts ERR_PTRs and
NULL pointers.

We don't need to set pkt->dfs_f_info to NULL in pkt_debugfs_dev_new()
because it was initialized with kzalloc() so I have removed that.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
drivers/block/pktcdvd.c