]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit - drivers/clk/clk-stm32f4.c
clk: stm32f4: avoid uninitialized variable access
authorArnd Bergmann <arnd@arndb.de>
Wed, 11 Jan 2017 13:40:52 +0000 (14:40 +0100)
committerStephen Boyd <sboyd@codeaurora.org>
Thu, 12 Jan 2017 22:06:07 +0000 (14:06 -0800)
commit89d5dcc48c08b4669a503e99e5f8dc7b5bcd2242
tree03ddc01a9a1308cfc2eebc6f69ca944b359621be
parent545643fddb4d15b5a8608856bd01ee158b1ec446
clk: stm32f4: avoid uninitialized variable access

The failure path in the newly added function tries to free an
uninitialized pointer:

drivers/clk/clk-stm32f4.c: In function 'stm32f4_rcc_init':
drivers/clk/clk-stm32f4.c:1106:4: error: 'gate' may be used uninitialized in this function [-Werror=maybe-uninitialized]

I'm adding an initialization to NULL here to make the kfree()
succeed, and I'm also rearranging the cleanup so that the
same kfree() is used for any error path, making the function
slightly more robust against newly introduced bugs in the
error handling.

Fixes: daf2d117cbca ("clk: stm32f4: Add lcd-tft clock")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Gabriel Fernandez <gabriel.fernandez@st.com>
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
drivers/clk/clk-stm32f4.c