]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commit - drivers/cpufreq/powernow-k8.c
cpufreq: powernow-k8: Initialize per-cpu data-structures properly
authorSrivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com>
Mon, 17 Feb 2014 10:48:21 +0000 (16:18 +0530)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Wed, 19 Feb 2014 00:04:56 +0000 (01:04 +0100)
commitc3274763bfc3bf1ececa269ed6e6c4d7ec1c3e5e
tree849fe849d4b6bde9c2aecd5c31ee519beff6c431
parent6964d91db2becfe80658f50584d264708ca7f49e
cpufreq: powernow-k8: Initialize per-cpu data-structures properly

The powernow-k8 driver maintains a per-cpu data-structure called
powernow_data that is used to perform the frequency transitions.
It initializes this data structure only for the policy->cpu. So,
accesses to this data structure by other CPUs results in various
problems because they would have been uninitialized.

Specifically, if a cpu (!= policy->cpu) invokes the drivers' ->get()
function, it returns 0 as the KHz value, since its per-cpu memory
doesn't point to anything valid. This causes problems during
suspend/resume since cpufreq_update_policy() tries to enforce this
(0 KHz) as the current frequency of the CPU, and this madness gets
propagated to adjust_jiffies() as well. Eventually, lots of things
start breaking down, including the r8169 ethernet card, in one
particularly interesting case reported by Pierre Ossman.

Fix this by initializing the per-cpu data-structures of all the CPUs
in the policy appropriately.

References: https://bugzilla.kernel.org/show_bug.cgi?id=70311
Reported-by: Pierre Ossman <pierre@ossman.eu>
Signed-off-by: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com>
Cc: All applicable <stable@vger.kernel.org>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/cpufreq/powernow-k8.c