]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit - drivers/cpuidle/cpuidle.c
cpuidle: add checks to avoid NULL pointer dereference
authorSrivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com>
Fri, 4 May 2012 21:06:02 +0000 (14:06 -0700)
committerLen Brown <len.brown@intel.com>
Fri, 1 Jun 2012 20:07:23 +0000 (16:07 -0400)
commit1b0a0e9a15b976d91f3b5ae619c6a8964c2818eb
tree4408c6a983c18ca7c8cc1a9d55008b3dd5d33703
parent0aeb9cac6f8a6fc68acfb07d30b62ad6106a6384
cpuidle: add checks to avoid NULL pointer dereference

The existing check for dev == NULL in __cpuidle_register_device() is
rendered useless because dev is dereferenced before the check itself.
Moreover, correctly speaking, it is the job of the callers of this
function, i.e., cpuidle_register_device() & cpuidle_enable_device() (which
also happen to be exported functions) to ensure that
__cpuidle_register_device() is called with a non-NULL dev.

So add the necessary dev == NULL checks in the two callers and remove the
(useless) check from __cpuidle_register_device().

Signed-off-by: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com>
Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Len Brown <len.brown@intel.com>
drivers/cpuidle/cpuidle.c