]> git.proxmox.com Git - mirror_ubuntu-zesty-kernel.git/commit - drivers/gpio/gpio-mvebu.c
gpio: mvebu: make mvchip->irqbase signed for error handling
authorDan Carpenter <dan.carpenter@oracle.com>
Thu, 7 Nov 2013 07:50:19 +0000 (10:50 +0300)
committerLinus Walleij <linus.walleij@linaro.org>
Mon, 25 Nov 2013 08:03:12 +0000 (09:03 +0100)
commitd535922691fc026479fcc03e78ac3d931a54e75a
tree046a205f2867e2b1c50c87284c08f572ec7f6104
parent53e7cac35db5941f42221314c33693e71ffa496b
gpio: mvebu: make mvchip->irqbase signed for error handling

There is a bug in mvebu_gpio_probe() where we do:

mvchip->irqbase = irq_alloc_descs(-1, 0, ngpios, -1);
if (mvchip->irqbase < 0) {

The problem is that mvchip->irqbase is unsigned so the error handling
doesn't work.  I have changed it to be a regular int.

Cc: stable@vger.kernel.org
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/gpio/gpio-mvebu.c