]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit - drivers/gpu/drm/i915/intel_drv.h
drm/i915: WARN when trying to enabled an unused crtc
authorDaniel Vetter <daniel.vetter@ffwll.ch>
Mon, 2 Jul 2012 09:43:47 +0000 (11:43 +0200)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Thu, 6 Sep 2012 05:57:45 +0000 (07:57 +0200)
commit08a48469691a1b9ed6ee92e726b66d4e59ffc253
treedb372ecdebb2e3f7e57c8c7b6985205c077a2ec6
parentdbf2b54e78c6976af1f92cd370055a777ae99208
drm/i915: WARN when trying to enabled an unused crtc

This is the first tiny step towards cross-checking the entire modeset
state machine with WARNs. A crtc can only be enabled when it's
actually in use, i.e. crtc->active imlies crtc->enabled.

Unfortunately we can't (yet) check this when disabling the crtc,
because the crtc helpers are a bit slopy with updating state and
unconditionally update crtc->enabled before changing the hw state.

Fixing that requires quite some more work.

Reviewed-by: Jesse Barnes <jbarnes@virtuousgeek.org>
Signed-Off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/i915/intel_display.c
drivers/gpu/drm/i915/intel_drv.h