]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commit - drivers/gpu/drm/msm/hdmi/hdmi_connector.c
drm/msm/hdmi: remove ->reset() from HDMI PHY
authorStephane Viau <sviau@codeaurora.org>
Fri, 19 Jun 2015 20:04:46 +0000 (16:04 -0400)
committerRob Clark <robdclark@gmail.com>
Sat, 15 Aug 2015 22:27:12 +0000 (18:27 -0400)
commitda32855219f86f27cad1b12be2264ffb0b97b9fa
treea685f61df2e77d23d438ebbcc13ff4362b57fdc0
parentdcefc117cc192f215d04c4e7cbae6b76a9bafcf4
drm/msm/hdmi: remove ->reset() from HDMI PHY

->reset() currently only accesses HDMI core registers, and yet it
is located in hdmi_phy*. Since no PHY registers are being
accessed during ->reset(), it would be better to bring that
function in hdmi core module where HDMI core registers are
usually being accessed.

This will also help for msm8x94 for which no PHY registers
accesses are done (->phy_init == NULL) but the HDMI PHY reset
from HDMI core still needs to be done.

Note:
SW_RESET_PLL bit is not written in hdmi_phy_8x60_reset(); this
write should not affect anything if the corresponding field is
not writable.

Signed-off-by: Stephane Viau <sviau@codeaurora.org>
[fixed warning about unused 'phy' in hpd_enable() while merging]
Signed-off-by: Rob Clark <robdclark@gmail.com>
drivers/gpu/drm/msm/hdmi/hdmi.h
drivers/gpu/drm/msm/hdmi/hdmi_connector.c
drivers/gpu/drm/msm/hdmi/hdmi_phy_8960.c
drivers/gpu/drm/msm/hdmi/hdmi_phy_8x60.c
drivers/gpu/drm/msm/hdmi/hdmi_phy_8x74.c