]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commit - drivers/gpu/drm/qxl/qxl_drv.c
qxl: fix null-pointer crash during suspend
authorPeter Wu <peter@lekensteyn.nl>
Tue, 4 Sep 2018 20:27:47 +0000 (22:27 +0200)
committerGerd Hoffmann <kraxel@redhat.com>
Wed, 5 Sep 2018 06:26:24 +0000 (08:26 +0200)
commit7948a2b15873319d1bff4d37c09b9f2bf87b9021
tree824091d005d823e1d04bd157814c60d7689fb681
parent5ddd6582cd7ba018b7527eed1777b7d83e6d9b62
qxl: fix null-pointer crash during suspend

"crtc->helper_private" is not initialized by the QXL driver and thus the
"crtc_funcs->disable" call would crash (resulting in suspend failure).
Fix this by converting the suspend/resume functions to use the
drm_mode_config_helper_* helpers.

Tested system sleep with QEMU 3.0 using "echo mem > /sys/power/state".
During suspend the following message is visible from QEMU:

    spice/server/display-channel.c:2425:display_channel_validate_surface: canvas address is 0x7fd05da68308 for 0 (and is NULL)
    spice/server/display-channel.c:2426:display_channel_validate_surface: failed on 0

This seems to be triggered by QXL_IO_NOTIFY_CMD after
QXL_IO_DESTROY_PRIMARY_ASYNC, but aside from the warning things still
seem to work (tested with both the GTK and -spice options).

Signed-off-by: Peter Wu <peter@lekensteyn.nl>
Link: http://patchwork.freedesktop.org/patch/msgid/20180904202747.14968-1-peter@lekensteyn.nl
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
drivers/gpu/drm/qxl/qxl_drv.c