]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit - drivers/infiniband/core/ucma.c
infiniband: fix a possible use-after-free bug
authorCong Wang <xiyou.wangcong@gmail.com>
Fri, 1 Jun 2018 18:31:44 +0000 (11:31 -0700)
committerJason Gunthorpe <jgg@mellanox.com>
Mon, 4 Jun 2018 15:37:03 +0000 (09:37 -0600)
commitcb2595c1393b4a5211534e6f0a0fbad369e21ad8
tree33be75d40a02b98c22b30fa6aa129d8850858f22
parente4b1672ac0a54c7740cbc4ff39dfdc56182236cb
infiniband: fix a possible use-after-free bug

ucma_process_join() will free the new allocated "mc" struct,
if there is any error after that, especially the copy_to_user().

But in parallel, ucma_leave_multicast() could find this "mc"
through idr_find() before ucma_process_join() frees it, since it
is already published.

So "mc" could be used in ucma_leave_multicast() after it is been
allocated and freed in ucma_process_join(), since we don't refcnt
it.

Fix this by separating "publish" from ID allocation, so that we
can get an ID first and publish it later after copy_to_user().

Fixes: c8f6a362bf3e ("RDMA/cma: Add multicast communication support")
Reported-by: Noam Rathaus <noamr@beyondsecurity.com>
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
drivers/infiniband/core/ucma.c