]> git.proxmox.com Git - mirror_ubuntu-zesty-kernel.git/commit - drivers/infiniband/ulp/isert/ib_isert.c
iser-target: Fix connected_handler + teardown flow race
authorSagi Grimberg <sagig@mellanox.com>
Tue, 2 Dec 2014 14:57:26 +0000 (16:57 +0200)
committerNicholas Bellinger <nab@linux-iscsi.org>
Sat, 13 Dec 2014 07:17:28 +0000 (23:17 -0800)
commit19e2090fb246ca21b3e569ead51a6a7a1748eadd
tree96acf88598b75b91c467e084f2fd7cdece8c274b
parent2371e5da8cfe91443339b54444dec6254fdd6dfc
iser-target: Fix connected_handler + teardown flow race

Take isert_conn pointer from cm_id->qp->qp_context. This
will allow us to know that the cm_id context is always
the network portal. This will make the cm_id event check
(connection or network portal) more reliable.

In order to avoid a NULL dereference in cma_id->qp->qp_context
we destroy the qp after we destroy the cm_id (and make the
dereference safe). session stablishment/teardown sequences
can happen in parallel, we should take into account that
connected_handler might race with connection teardown flow.

Also, protect isert_conn->conn_device->active_qps decrement
within the error patch during QP creation failure and the
normal teardown path in isert_connect_release().

Squashed:

iser-target: Decrement completion context active_qps in error flow

Signed-off-by: Sagi Grimberg <sagig@mellanox.com>
Cc: <stable@vger.kernel.org> # v3.10+
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
drivers/infiniband/ulp/isert/ib_isert.c