]> git.proxmox.com Git - mirror_ubuntu-zesty-kernel.git/commit - drivers/infiniband/ulp/isert/ib_isert.c
iscsi/iser-target: Fix isert_conn->state hung shutdown issues
authorNicholas Bellinger <nab@linux-iscsi.org>
Mon, 3 Feb 2014 20:54:39 +0000 (12:54 -0800)
committerNicholas Bellinger <nab@linux-iscsi.org>
Wed, 5 Mar 2014 01:54:09 +0000 (17:54 -0800)
commitdefd884845297fd5690594bfe89656b01f16d87e
treeb8ae8a15462e2ccc2e0a6c1c1f7ace6507a47aa5
parent5159d763f60af693a3fcec45dce2021f66e528a4
iscsi/iser-target: Fix isert_conn->state hung shutdown issues

This patch addresses a couple of different hug shutdown issues
related to wait_event() + isert_conn->state.  First, it changes
isert_conn->conn_wait + isert_conn->conn_wait_comp_err from
waitqueues to completions, and sets ISER_CONN_TERMINATING from
within isert_disconnect_work().

Second, it splits isert_free_conn() into isert_wait_conn() that
is called earlier in iscsit_close_connection() to ensure that
all outstanding commands have completed before continuing.

Finally, it breaks isert_cq_comp_err() into seperate TX / RX
related code, and adds logic in isert_cq_rx_comp_err() to wait
for outstanding commands to complete before setting ISER_CONN_DOWN
and calling complete(&isert_conn->conn_wait_comp_err).

Acked-by: Sagi Grimberg <sagig@mellanox.com>
Cc: Or Gerlitz <ogerlitz@mellanox.com>
Cc: <stable@vger.kernel.org> #3.10+
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
drivers/infiniband/ulp/isert/ib_isert.c
drivers/infiniband/ulp/isert/ib_isert.h
drivers/target/iscsi/iscsi_target.c
include/target/iscsi/iscsi_transport.h