]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commit - drivers/mfd/motorola-cpcap.c
mfd: cpcap: Fix interrupt to use level interrupt
authorTony Lindgren <tony@atomide.com>
Tue, 4 Apr 2017 03:15:54 +0000 (20:15 -0700)
committerLee Jones <lee.jones@linaro.org>
Thu, 27 Apr 2017 08:25:07 +0000 (09:25 +0100)
commitac89473213c602b98172d92e40f5e78032b1aba0
treeed3cc6fe23d2c778ff7f3cd34c683ac7f3829f50
parent4d5db2a3a207451a8b11802c4d5f45a8931d996c
mfd: cpcap: Fix interrupt to use level interrupt

I made a mistake assuming the device tree configuration for interrupt
triggering was somehow passed to the SPI device but it's not.

In the Motorola Linux kernel tree CPCAP PMIC is configured as a rising
edge triggered interrupt, but then then it's interrupt handler keeps
looping until the GPIO line goes down. So the CPCAP interrupt is clearly
a level interrupt and not an edge interrupt.

Earlier when I tried to configure it as level interrupt using the
device tree, I did not account that the triggering only gets passed
to the SPI core and it also needs to be specified in the CPCAP driver
when we do devm_regmap_add_irq_chip().

Fixes: 56e1d40d3bea ("mfd: cpcap: Add minimal support")
Signed-off-by: Tony Lindgren <tony@atomide.com>
Acked-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
drivers/mfd/motorola-cpcap.c