]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commit - drivers/net/ethernet/qlogic/qed/qed_ll2.c
qed: Fix copy of uninitialized memory
authorrobert.foss@collabora.com <robert.foss@collabora.com>
Tue, 7 Mar 2017 16:46:25 +0000 (11:46 -0500)
committerDavid S. Miller <davem@davemloft.net>
Thu, 9 Mar 2017 21:18:09 +0000 (13:18 -0800)
commit8aad6f14c09d78862fc04e47214d398add9bb8ce
tree72a1fb0ddf9442b90ab0b4157b2519fea83cafe3
parentc021aaca5feb39f5853d10fdedb17043848b48b9
qed: Fix copy of uninitialized memory

In qed_ll2_start_ooo() the ll2_info variable is uninitialized and then
passed to qed_ll2_acquire_connection() where it is copied into a new
memory space.

This shouldn't cause any issue as long as non of the copied memory is
every read.
But the potential for a bug being introduced by reading this memory
is real.

Detected by CoverityScan, CID#1399632 ("Uninitialized scalar variable")

Signed-off-by: Robert Foss <robert.foss@collabora.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/qlogic/qed/qed_ll2.c