]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit - drivers/nvme/host/pci.c
nvme-pci: avoid hmb desc array idx out-of-bound when hmmaxd set.
authorMinwoo Im <minwoo.im.dev@gmail.com>
Thu, 16 Nov 2017 16:34:24 +0000 (01:34 +0900)
committerChristoph Hellwig <hch@lst.de>
Mon, 20 Nov 2017 07:38:09 +0000 (08:38 +0100)
commit244a8fe40a09c218622eb9927b9090b0a9b73a1a
tree424bb4b4200a3c7a4fd36d793d2cf729f8a9a844
parent8427bbc224863e14d905c87920d4005cb3e88ac3
nvme-pci: avoid hmb desc array idx out-of-bound when hmmaxd set.

hmb descriptor idx out-of-bound occurs in case of below conditions.
preferred = 128MiB
chunk_size = 4MiB
hmmaxd = 1

Current code will not allow rmmod which will free hmb descriptors
to be done successfully in above case.

"descs[i]" will be set in for-loop without seeing any conditions
related to "max_entries" after a single "descs" was allocated by
(max_entries = 1) in this case.

Added a condition into for-loop to check index of descriptors.

Fixes: 044a9df1("nvme-pci: implement the HMB entry number and size limitations")
Signed-off-by: Minwoo Im <minwoo.im.dev@gmail.com>
Reviewed-by: Keith Busch <keith.busch@intel.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
drivers/nvme/host/pci.c