]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit - drivers/nvme/host/pci.c
nvme: Don't suspend admin queue that wasn't created
authorGabriel Krisman Bertazi <krisman@linux.vnet.ibm.com>
Tue, 6 Sep 2016 20:39:13 +0000 (17:39 -0300)
committerJens Axboe <axboe@fb.com>
Wed, 7 Sep 2016 14:53:21 +0000 (08:53 -0600)
commit82469c59d222f839ded5cd282172258e026f9112
treeafa8c5ae402d70b803373656b6afa069b93bea69
parentc6935931c1894ff857616ff8549b61236a19148f
nvme: Don't suspend admin queue that wasn't created

This fixes a regression in my previous commit c21377f8366c ("nvme:
Suspend all queues before deletion"), which provoked an Oops in the
removal path when removing a device that became IO incapable very early
at probe (i.e. after a failed EEH recovery).

Turns out, if the error occurred very early at the probe path, before
even configuring the admin queue, we might try to suspend the
uninitialized admin queue, accessing bad memory.

Fixes: c21377f8366c ("nvme: Suspend all queues before deletion")
Signed-off-by: Gabriel Krisman Bertazi <krisman@linux.vnet.ibm.com>
Reviewed-by: Jay Freyensee <james_p_freyensee@linux.intel.com>
Signed-off-by: Jens Axboe <axboe@fb.com>
drivers/nvme/host/pci.c