]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commit - drivers/nvme/host/pci.c
NVMe: Always use MSI/MSI-x interrupts
authorKeith Busch <keith.busch@intel.com>
Fri, 8 Apr 2016 22:09:10 +0000 (16:09 -0600)
committerJens Axboe <axboe@fb.com>
Thu, 14 Apr 2016 20:04:50 +0000 (14:04 -0600)
commita5229050b69cfffb690b546c357ca5a60434c0c8
treebde4ca622d6703804bf474b57eea4aadf0ef73b2
parent9bf2b972afeaffd173fe2ce211ebc555ea7e8a87
NVMe: Always use MSI/MSI-x interrupts

Multiple users have reported device initialization failure due the driver
not receiving legacy PCI interrupts. This is not unique to any particular
controller, but has been observed on multiple platforms.

There have been no issues reported or observed when with message signaled
interrupts, so this patch attempts to use MSI-x during initialization,
falling back to MSI. If that fails, legacy would become the default.

The setup_io_queues error handling had to change as a result: the admin
queue's msix_entry used to be initialized to the legacy IRQ. The case
where nr_io_queues is 0 would fail request_irq when setting up the admin
queue's interrupt since re-enabling MSI-x fails with 0 vectors, leaving
the admin queue's msix_entry invalid. Instead, return success immediately.

Reported-by: Tim Muhlemmer <muhlemmer@gmail.com>
Reported-by: Jon Derrick <jonathan.derrick@intel.com>
Signed-off-by: Keith Busch <keith.busch@intel.com>
Signed-off-by: Jens Axboe <axboe@fb.com>
drivers/nvme/host/pci.c