]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit - drivers/remoteproc/qcom_q6v5_pil.c
remoteproc: qcom: fix initializers for qcom_mss_reg_res array
authorArnd Bergmann <arnd@arndb.de>
Wed, 1 Feb 2017 16:56:28 +0000 (17:56 +0100)
committerBjorn Andersson <bjorn.andersson@linaro.org>
Wed, 1 Feb 2017 09:22:21 +0000 (01:22 -0800)
commitec671b5360b914fb3ad79053593d195996a95dde
treeb47b0f79ef09998c8ef74d52bd89ac01c983993d
parent2099c77d4af7d1582db6d4437014cf18fe62e74b
remoteproc: qcom: fix initializers for qcom_mss_reg_res array

The recently added initialization is rather unusual because it uses a constructor for
a variable-length array to assign a constant structure to a member that uses a fixed-length
array. This confuses clang and breaks the build.

drivers/remoteproc/qcom_q6v5_pil.c:1024:18: error: incompatible pointer types initializing 'const char *' with an expression of type
:%s      'struct qcom_mss_reg_res [4]' [-Werror,-Wincompatible-pointer-types]
        .proxy_supply = (struct qcom_mss_reg_res[]) {
                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/remoteproc/qcom_q6v5_pil.c:1024:18: warning: suggest braces around initialization of subobject [-Wmissing-braces]
        .proxy_supply = (struct qcom_mss_reg_res[]) {
                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~

We can either turn this constructor into a regular initializer by removing
the 'struct qcom_mss_reg_res[])', or we can make the array variable length.

The latter approach is used for the arrays of strings in the same structure,
so let's use that here too.

Fixes: 19f902b53b47 ("remoteproc: qcom: Initialize and enable proxy and active regulators.")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
drivers/remoteproc/qcom_q6v5_pil.c