]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit - drivers/scsi/Kconfig
scsi: use 'depends' instead of 'select' for SCSI_FC_ATTRS
authorRandy Dunlap <rdunlap@infradead.org>
Tue, 16 Sep 2014 20:47:41 +0000 (13:47 -0700)
committerDavid S. Miller <davem@davemloft.net>
Tue, 16 Sep 2014 20:55:55 +0000 (16:55 -0400)
commit6a38792ca8a5da28f65dc42eeb73d9a431f8d0fd
treef62a2bfc7fdb26d92fd2736f39c7890e34fd815f
parentf650fb456f2079b762c131a11397c0a966e2bfe4
scsi: use 'depends' instead of 'select' for SCSI_FC_ATTRS

There are other kconfig symbols which use SCSI_FC_ATTRS.
In order to maintain sanity and prevent kconfig warnings, change
all of these from using 'select' to using 'depends on' so that
proper symbol dependencies will be honored and circular depends
problems will be avoided.
This fixes kconfig warnings and build errors:

warning: (LIBFC && SCSI_IBMVFC && SCSI_QLA_FC && SCSI_LPFC && ZFCP && SCSI_BFA_FC && SCSI_CHELSIO_FCOE && FUSION_FC) selects SCSI_FC_ATTRS which has unmet direct dependencies (SCSI && NET)
drivers/scsi/scsi_transport_fc.c: In function 'fc_host_post_event':
drivers/scsi/scsi_transport_fc.c:543:7: error: 'scsi_nl_sock' undeclared (first use in this function)
drivers/scsi/scsi_transport_fc.c: In function 'fc_host_post_vendor_event':
drivers/scsi/scsi_transport_fc.c:611:7: error: 'scsi_nl_sock' undeclared (first use in this function)

Reported-by: Fengguang Wu <fengguang.wu@intel.com> [0-day test robot]
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/message/fusion/Kconfig
drivers/scsi/Kconfig
drivers/scsi/csiostor/Kconfig
drivers/scsi/qla2xxx/Kconfig