]> git.proxmox.com Git - mirror_ubuntu-zesty-kernel.git/commit - drivers/scsi/NCR5380.c
ncr5380: Move static PDMA spin counters to host data
authorFinn Thain <fthain@telegraphics.com.au>
Wed, 12 Nov 2014 05:11:59 +0000 (16:11 +1100)
committerChristoph Hellwig <hch@lst.de>
Thu, 20 Nov 2014 08:11:09 +0000 (09:11 +0100)
commita9c2dc43c14cc9e9333d451bc4db8a827a695332
tree70e239cb8ebf6f09fa6d4c37cb3cc2884a37d144
parent8c32513bd395dc5d382e4883097482567cf8bbc5
ncr5380: Move static PDMA spin counters to host data

Static variables from dtc.c and pas16.c should not appear in the core
NCR5380.c driver. Aside from being a layering issue this worsens the
divergence between the three core driver variants (atari_NCR5380.c and
sun3_NCR5380.c don't support PSEUDO_DMA) and it can mean multiple hosts
share the same counters.

Fix this by making the pseudo DMA spin counters in the core more generic.
This also avoids the abuse of the {DTC,PAS16}_PUBLIC_RELEASE macros, so
they can be removed.

oak.c doesn't use PDMA and hence it doesn't use the counters and hence it
needs no write_info() method. Remove it.

Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Tested-by: Michael Schmitz <schmitzmic@gmail.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
drivers/scsi/NCR5380.c
drivers/scsi/NCR5380.h
drivers/scsi/arm/oak.c
drivers/scsi/dtc.c
drivers/scsi/pas16.c