]> git.proxmox.com Git - mirror_ubuntu-zesty-kernel.git/commit - drivers/scsi/cxlflash/main.c
scsi: cxlflash: Scan host only after the port is ready for I/O
authorUma Krishnan <ukrishn@linux.vnet.ibm.com>
Fri, 2 Sep 2016 20:38:48 +0000 (15:38 -0500)
committerMartin K. Petersen <martin.petersen@oracle.com>
Fri, 9 Sep 2016 11:34:18 +0000 (07:34 -0400)
commitbbbfae962b7c221237c0f92547ee0c83f7204747
treece67fc156620def77fd00d391bf3a89e5dea59d6
parent6c46301fc5f8e6f230b9bc92a0eca3bc568918a3
scsi: cxlflash: Scan host only after the port is ready for I/O

When a port link is established, the AFU sends a 'link up' interrupt.
After the link is up, corresponding initialization steps are performed
on the card. Following that, when the card is ready for I/O, the AFU
sends 'login succeeded' interrupt. Today, cxlflash invokes
scsi_scan_host() upon receipt of both interrupts.

SCSI commands sent to the port prior to the 'login succeeded' interrupt
will fail with 'port not available' error. This is not desirable.
Moreover, when async_scan is active for the host, subsequent scan calls
are terminated with error. Due to this, the scsi_scan_host() call
performed after 'login succeeded' interrupt could portentially return
error and the devices may not be scanned properly.

To avoid this problem, scsi_scan_host() should be called only after the
'login succeeded' interrupt.

Signed-off-by: Uma Krishnan <ukrishn@linux.vnet.ibm.com>
Acked-by: Matthew R. Ochs <mrochs@linux.vnet.ibm.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/cxlflash/main.c