]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commit - drivers/scsi/cxlflash/vlun.c
scsi: cxlflash: Fix vlun resize failure in the shrink path
authorUma Krishnan <ukrishn@linux.vnet.ibm.com>
Fri, 25 Aug 2017 22:18:12 +0000 (17:18 -0500)
committerMartin K. Petersen <martin.petersen@oracle.com>
Fri, 25 Aug 2017 22:24:04 +0000 (18:24 -0400)
commit07a191f762a7b8d0db13c38036380927116e29bb
tree5e6b730c1f96ae3d12ce46b17b2bfeddfc4b099c
parent1a9e394154e34728f58c1f697b993aaaf89a4db2
scsi: cxlflash: Fix vlun resize failure in the shrink path

The ioctl DK_CAPI_VLUN_RESIZE can fail if the allocated vlun size is
reduced from almost maximum capacity and then increased again.

The shrink_lxt() routine is currently using the SISL_ASTATUS_MASK to
mask the higher 48 bits of the lxt entry. This is unnecessary and
incorrect as it uses a mask designed for the asynchronous interrupt
status register.  When the 4 port support was added to cxlflash, the
SISL_ASTATUS_MASK was updated to reflect the status bits for all 4
ports. This change indirectly affected the shrink_lxt() code path.

To extract the base, simply shift the bits without masking.

Fixes: 565180723294 ("scsi: cxlflash: SISlite updates to support 4 ports")
Signed-off-by: Uma Krishnan <ukrishn@linux.vnet.ibm.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/cxlflash/vlun.c