]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit - drivers/scsi/fnic/fnic_main.c
[SCSI] fnic: Allocate OS interrupt resources just before enabling interrupts
authorAbhijeet Joglekar <abjoglek@cisco.com>
Tue, 3 Nov 2009 19:45:37 +0000 (11:45 -0800)
committerJames Bottomley <James.Bottomley@suse.de>
Fri, 4 Dec 2009 18:00:52 +0000 (12:00 -0600)
commit2e76f7670b33a3b0bdf015ed1459e4b417a40ce0
tree6a361c53f41f848179fd8196d53ccfaeb6dcc32b
parent65d430fa99cbd0e88d09a3343f697c51fc8a7009
[SCSI] fnic: Allocate OS interrupt resources just before enabling interrupts

The OS interrupt vectors were getting allocated before the interrupt
resources were mapped from hardware. For Legacy interrupts, since
they are shared with other devices, as soon as an interrupt is
registered with the OS, it can fire while the fnic isr resource is
still unmapped. This can cause crash because of access to unmapped resources.
For MSIX and MSI, since interrupts are not shared with other devices,
this problem didnt happen, because the interrupt is enabled as the last
step before returning from _probe. For Legacy however, since the
interrupt is shared, the handler can be called as soon as it is registered.

Solution is to register interrupt handlers with OS as last step before
enabling device interrupts.

Signed-off-by: Abhijeet Joglekar <abjoglek@cisco.com>
Signed-off-by: Robert Love <robert.w.love@intel.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
drivers/scsi/fnic/fnic_main.c