]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commit - drivers/scsi/lpfc/lpfc_sli.c
scsi: lpfc: Fix hard lock up NMI in els timeout handling.
authorDick Kennedy <dick.kennedy@broadcom.com>
Tue, 7 Nov 2017 20:59:02 +0000 (12:59 -0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Wed, 8 Nov 2017 23:25:12 +0000 (18:25 -0500)
commit341b2aa83368e6f23bf0cc3d04604896337ad7cb
treee7858cc574c7a7e1c7ac3eab3536f7fef90a5e16
parent268eb4989410619c39b041d453a05a71b26b24c6
scsi: lpfc: Fix hard lock up NMI in els timeout handling.

System crashed due to a hard lockup at lpfc_els_timeout_handler+0x128.

The els ring's txcmplq list is corrupted: the last element in the list
does not point back the the head causing a loop. Issue is the els
processing path for sli4 hbas are using the hbalock instead of the
ring_lock for removing elements from the txcmplq list.

Use the adapter SLI_REV to determine which lock should be used for
removing iocbqs from the els rings txcmplq.

note: the future refactoring will address this so that we don't have
this ugly type-based lock code.

Signed-off-by: Dick Kennedy <dick.kennedy@broadcom.com>
Signed-off-by: James Smart <james.smart@broadcom.com>
Reviewed-by: Ewan D. Milne <emilne@redhat.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/lpfc/lpfc_sli.c