]> git.proxmox.com Git - mirror_ubuntu-zesty-kernel.git/commit - drivers/scsi/scsi_lib.c
scsi: return correct blkprep status code in case scsi_init_io() fails.
authorJohannes Thumshirn <jthumshirn@suse.de>
Wed, 12 Apr 2017 07:21:19 +0000 (09:21 +0200)
committerThadeu Lima de Souza Cascardo <cascardo@canonical.com>
Wed, 17 May 2017 16:39:10 +0000 (13:39 -0300)
commit80877be189922ff5d7b4d6e2834e62f790785f77
tree59bfee6d08fc10cbc9f88dd4f44a2344e3039c9d
parentab17c1b4e7b01462d881825b03222ed404068318
scsi: return correct blkprep status code in case scsi_init_io() fails.

BugLink: http://bugs.launchpad.net/bugs/1688499
commit e7661a8e5ce10b5321882d0bbaf3f81070903319 upstream.

When instrumenting the SCSI layer to run into the
!blk_rq_nr_phys_segments(rq) case the following warning emitted from the
block layer:

blk_peek_request: bad return=-22

This happens because since commit fd3fc0b4d730 ("scsi: don't BUG_ON()
empty DMA transfers") we return the wrong error value from
scsi_prep_fn() back to the block layer.

[mkp: silenced checkpatch]

Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de>
Fixes: fd3fc0b4d730 scsi: don't BUG_ON() empty DMA transfers
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Hannes Reinecke <hare@suse.com>
Reviewed-by: Bart Van Assche <bart.vanassche@sandisk.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@canonical.com>
drivers/scsi/scsi_lib.c