]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commit - drivers/scsi/st.c
scsi: st: fix blk_get_queue usage
authorBodo Stroesser <bstroesser@ts.fujitsu.com>
Tue, 1 Aug 2017 12:42:54 +0000 (14:42 +0200)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 8 Aug 2017 15:49:51 +0000 (11:49 -0400)
commit180efde0a3f43dbe533e4be203c2918793482d4e
tree0c9dd7e01d8e3d00c2e634fd378feee39cb45569
parentbe37aa4b993bd5d4191f76a7bd43be33f987b972
scsi: st: fix blk_get_queue usage

If blk_queue_get() in st_probe fails, disk->queue must not be set to
SDp->request_queue, as that would result in put_disk() dropping a not
taken reference.

Thus, disk->queue should be set only after a successful blk_queue_get().

Fixes: 2b5bebccd282 ("st: Take additional queue ref in st_probe")
Signed-off-by: Bodo Stroesser <bstroesser@ts.fujitsu.com>
Acked-by: Shirish Pargaonkar <spargaonkar@suse.com>
Signed-off-by: Hannes Reinecke <hare@suse.com>
Reviewed-by: Ewan D. Milne <emilne@redhat.com>
Acked-by: Kai Mäkisara <kai.makisara@kolumbus.fi>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/st.c