]> git.proxmox.com Git - mirror_ubuntu-zesty-kernel.git/commit - drivers/spi/spi-topcliff-pch.c
spi: topcliff-pch: Pass correct pointer to free_irq()
authorLars-Peter Clausen <lars@metafoo.de>
Mon, 20 May 2013 15:54:35 +0000 (17:54 +0200)
committerMark Brown <broonie@opensource.wolfsonmicro.com>
Mon, 20 May 2013 16:24:13 +0000 (11:24 -0500)
commite1e5762823be84cb97f629bdfecb97af3d187406
tree7d93e6f276b17025892619faf337a83623c0817b
parentf722406faae2d073cc1d01063d1123c35425939e
spi: topcliff-pch: Pass correct pointer to free_irq()

free_irq() expects the same pointer that was passed to request_irq(), otherwise
the IRQ is not freed.

The issue was found using the following coccinelle script:

<smpl>
@r1@
type T;
T devid;
@@
request_irq(..., devid)

@r2@
type r1.T;
T devid;
position p;
@@
free_irq@p(..., devid)

@@
position p != r2.p;
@@
*free_irq@p(...)
</smpl>

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
drivers/spi/spi-topcliff-pch.c