]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commit - drivers/target/iscsi/iscsi_target_util.c
iscsi-target: use strlcpy in iscsit_collect_login_stats
authorJoern Engel <joern@logfs.org>
Tue, 2 Sep 2014 21:49:55 +0000 (17:49 -0400)
committerNicholas Bellinger <nab@linux-iscsi.org>
Wed, 17 Sep 2014 20:54:38 +0000 (13:54 -0700)
commitfdc84d11a278d468052afc8e17523545fafe6c5f
tree278fa117625f9e5140d2af3d11ea03f24b4ad116
parent94e16e9c59312247de199b5f9bf141d1bd946dd0
iscsi-target: use strlcpy in iscsit_collect_login_stats

last_intr_fail_name is a fixed-size array and could theoretically
overflow.  In reality intrname->value doesn't seem to depend on
untrusted input or be anywhere near 224 characters, so the overflow is
pretty theoretical.  But strlcpy is cheap enough.

Found by coverity.

Signed-off-by: Joern Engel <joern@logfs.org>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
drivers/target/iscsi/iscsi_target_util.c