]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commit - drivers/target/target_core_transport.c
target: Fix COMPARE_AND_WRITE caw_sem leak during se_cmd quiesce
authorJiang Yi <jiangyilism@gmail.com>
Sun, 25 Jun 2017 19:28:50 +0000 (12:28 -0700)
committerNicholas Bellinger <nab@linux-iscsi.org>
Fri, 7 Jul 2017 06:11:32 +0000 (23:11 -0700)
commit1d6ef276594a781686058802996e09c8550fd767
tree8b16ce1b714d58ac623249d33fb908c343bacf51
parent8a45885c1514cdae2ee64b5ac03ffc00a1a8a9d7
target: Fix COMPARE_AND_WRITE caw_sem leak during se_cmd quiesce

This patch addresses a COMPARE_AND_WRITE se_device->caw_sem leak,
that would be triggered during normal se_cmd shutdown or abort
via __transport_wait_for_tasks().

This would occur because target_complete_cmd() would catch this
early and do complete_all(&cmd->t_transport_stop_comp), but since
target_complete_ok_work() or target_complete_failure_work() are
never called to invoke se_cmd->transport_complete_callback(),
the COMPARE_AND_WRITE specific callbacks never release caw_sem.

To address this special case, go ahead and release caw_sem
directly from target_complete_cmd().

(Remove '&& success' from check, to release caw_sem regardless
 of scsi_status - nab)

Signed-off-by: Jiang Yi <jiangyilism@gmail.com>
Cc: <stable@vger.kernel.org> # 3.14+
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
drivers/target/target_core_transport.c