]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commit - drivers/target/target_core_transport.c
target: simplify code around transport_get_sense_data
authorPaolo Bonzini <pbonzini@redhat.com>
Wed, 5 Sep 2012 15:09:14 +0000 (17:09 +0200)
committerNicholas Bellinger <nab@linux-iscsi.org>
Thu, 6 Sep 2012 00:20:19 +0000 (17:20 -0700)
commit27a2709912ac19c755d34c79fe11994b0bf8082b
tree8e8e0a2a88f9bc8e807a9a7bac8756de43aaa37c
parent6138ed2ab8791d7a9c5ba66cadadd5eaf1fc1dac
target: simplify code around transport_get_sense_data

The error conditions in transport_get_sense_data are superfluous
and complicate the code unnecessarily:

* SCF_TRANSPORT_TASK_SENSE is checked in the caller;

* it's simply part of the invariants of dev->transport->get_sense_buffer
  that it must be there if transport_complete ever returns 1, and that
  it must not return NULL.  Besides, the entire callback will disappear
  with the next patch.

* similarly in the caller we can expect that sense data is only sent
  for non-zero cmd->scsi_status.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Cc: stable@vger.kernel.org
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
drivers/target/target_core_transport.c