]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commit - drivers/target/target_core_transport.c
target: Release COMPARE_AND_WRITE mutex in generic failure path
authorNicholas Bellinger <nab@daterainc.com>
Thu, 22 Aug 2013 02:34:43 +0000 (19:34 -0700)
committerNicholas Bellinger <nab@linux-iscsi.org>
Tue, 10 Sep 2013 23:46:01 +0000 (16:46 -0700)
commitcf6d1f0964fa9db57fc660caf51939d7a03359a1
tree444f6f52a73ad35cf2b287adf23b15a8a05c9ba2
parenta2890087499ae530362139aaf6c120f438e1e679
target: Release COMPARE_AND_WRITE mutex in generic failure path

This patch adds a extra check for SCF_COMPARE_AND_WRITE within
transport_generic_request_failure() to invoke the callback for
compare_and_write_callback() or compare_and_write_done(), in
order to release se_dev->caw_mutex from the generic failure
path.

It also adds to checks within compare_and_write_callback() to
avoid processing when transport_generic_request_failure() occurs
early enough that cmd->t_data_sg or cmd->t_bidi_data_sg have not
been setup yet, nor se_dev->caw_mutex obtained from within
sbc_compare_and_write().

v4 changes:
 - Add explicit check for cmd->transport_complete_callback in
   transport_generic_request_failure() to handle case where
   sbc_compare_and_write()clears callback pointer (Dan Carpenter)

Cc: Christoph Hellwig <hch@lst.de>
Cc: Hannes Reinecke <hare@suse.de>
Cc: Martin Petersen <martin.petersen@oracle.com>
Cc: Chris Mason <chris.mason@fusionio.com>
Cc: James Bottomley <JBottomley@Parallels.com>
Cc: Nicholas Bellinger <nab@linux-iscsi.org>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
drivers/target/target_core_sbc.c
drivers/target/target_core_transport.c