]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commit - drivers/tty/n_gsm.c
n_gsm: added interlocking for gsm_data_lock for certain code paths
authorRuss Gorby <russ.gorby@intel.com>
Mon, 13 Aug 2012 12:44:40 +0000 (13:44 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 16 Aug 2012 19:03:30 +0000 (12:03 -0700)
commit5e44708f75b0f8712da715d6babb0c21089b2317
treee5f4f2ecd25649b5d47589ba2cf919c4e92ed222
parent10c6c383e43565c9c6ec07ff8eb2825f8091bdf0
n_gsm: added interlocking for gsm_data_lock for certain code paths

There were some locking holes in the management of the MUX's
message queue for 2 code paths:
1) gsmld_write_wakeup
2) receipt of CMD_FCON flow-control message
In both cases gsm_data_kick is called w/o locking so it can collide
with other other instances of gsm_data_kick (pulling messages tx_tail)
or potentially other instances of __gsm_data_queu (adding messages to tx_head)

Changed to take the tx_lock in these 2 cases

Signed-off-by: Russ Gorby <russ.gorby@intel.com>
Tested-by: Yin, Fengwei <fengwei.yin@intel.com>
Signed-off-by: Alan Cox <alan@linux.intel.com>
Cc: Riding School <stable@vger.kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/n_gsm.c