]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commit - drivers/tty/tty_io.c
tty: Fix ioctl(FIOASYNC) on hungup file
authorPeter Hurley <peter@hurleysoftware.com>
Sun, 10 Jan 2016 05:45:11 +0000 (21:45 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 28 Jan 2016 19:58:02 +0000 (11:58 -0800)
commita8f3a29718f77df3116955d100756f67fafabec0
tree435e824fef69ff9d08e6df6baf06fde5a31c2b5e
parentf557474ca3a23800dffb790846bcb121fa046c71
tty: Fix ioctl(FIOASYNC) on hungup file

A small race window exists which allows signal-driven async i/o to be
enabled for the tty when the file ptr has already been hungup and
signal-driven i/o has been disabled:

CPU 0                                CPU 1
-----                                ------
ioctl_fioasync(on)
  filp->f_op->fasync(on)             __tty_hangup()
    tty_fasync(on)                     tty_lock()
      tty_lock()                       ...
        .                              filp->f_op = &hung_up_tty_fops;
      (waiting)                       __tty_fasync(off)
        .                              tty_unlock()
      /* gets tty lock  */
      /* enables FASYNC */

Check the tty has not been hungup while holding tty_lock.

Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/tty_io.c